[Libreoffice] [PUSHED] Re: [PATCH 6/9] waring cleaning in sw_sw3redln.cxx

Caolán McNamara caolanm at redhat.com
Fri Nov 26 05:20:48 PST 2010

On Fri, 2010-11-26 at 14:12 +0100, Joachim Trémouroux wrote:
> Pierre-André,
> Are you sure it is safe to remove the OpenFlagRec() call ?

Indeed, good catch Joachim. The warning is that the ret value of
OpenFlagRec is unused, looking closed at OpenFlagRec you'll see that it
extracts a value from the underlying stream, so that stream is advanced
by 2 bytes, dropping the call would change that logic. The right fix is
to just drop the BYTE cDFlags =. 

I've fixed this now. Michael has already pushed the remainder of this
patch at least.


More information about the LibreOffice mailing list