[Libreoffice] [PATCH 4/9] binfilter sc_interpr4.cxx further warnings removal

Caolán McNamara caolanm at redhat.com
Fri Nov 26 05:38:36 PST 2010


On Fri, 2010-11-26 at 07:55 +0100, Pierre-André Jacquod wrote:
> regards

Mostly good, though while the return value of GetStackType() is usused,
looking closer at GetStackType() there is a potential route (the
SetError one) where GetStackType() changes the state of the Document. So
its safer to just remove the variable that takes the return value and
restore the call to GetStackType().

Done that now and Michael pushed the rest. Thanks for this.

C.



More information about the LibreOffice mailing list