[Libreoffice] [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

Jordan Ayers jordan.ayers at gmail.com
Tue Nov 30 21:02:45 PST 2010


    Another performance improvement for the perl installer.  This one
brought my ./bin/ooinstall -l <dirname> time down from about 4 1/2
minutes to under 4 minutes.  (Warning:  that number is in the right
ballpark, but is from a very small number of install runs.)  The only
functional change was to trim all leading/trailing whitespace from the
list elements before eliminating duplicates (the old function only
checks half of the leading/trailing edges, and which edge depends on
where in the list the element came from; I couldn't find a good reason
for that pattern, so I made it uniform).

    I'm finding the NYTProf module useful for finding performance
bottlenecks in the perl code, although on my system the times seem to
bloat out by a factor of 3 or so with the profiler running.

LGPLv3+/MPL.

Jordan Ayers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Accelerate-perl-installer-optimize-installer-scripti.patch
Type: text/x-patch
Size: 1491 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20101130/949bbf02/attachment.bin>


More information about the LibreOffice mailing list