[Libreoffice] [PATCH] printf without format considered harmful

Michael Meeks michael.meeks at novell.com
Mon Oct 4 02:57:50 PDT 2010

Hi Norbert,

On Sun, 2010-10-03 at 14:24 -0500, Norbert Thiebaud wrote:
> [PATCH] printf without format considered harmful

	Great patch :-) good to know that that is cleaned up globally. Glad to
see Cedric committed it already.

> -                printf( ByteString( aPrintMsg, RTL_TEXTENCODING_UTF8
> ).GetBuffer() );
> +                printf( "%s", ByteString( aPrintMsg,
> RTL_TEXTENCODING_UTF8 ).GetBuffer() );

	Line wrapping is a bit of a pain in patch mails though ;-)



PS. you seem to have a gold-mine of easy-type hacks up your sleeve, any
chance you could add some of these to the wiki page and leave them for
the less obviously competant ? :-)
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list