[Libreoffice] Fwd: [PATCH] Add support for bool for the operator << and >> of SvStream

[Norbert Thiebaud]

I keep forgetting to 'reply to all' so the response doesn't go to the list
---------- Forwarded message ----------
From: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Mon, 4 Oct 2010 09:59:23 -0500
Subject: Re: [Libreoffice] [PATCH] Add support for bool for the
operator << and >> of SvStream
To: Noel Power <nopower at novell.com>

On 10/4/10, Noel Power <nopower at novell.com> wrote:
> Hi Norbet
> On Sat, 2010-10-02 at 21:18 -0500, Norbert Thiebaud wrote:
>> [PATCH] Add support for bool for the operator << and >> of SvStream
>>
> I just wonder did you have a specific reason for this patch. I would
> assume if someone would be reading or writing a boolean value to a
> binary stream they probably would be packing it some how in the
> structure they are writing. E.g. normally in the binary filters ( where
> SvStream is used ) boolean values are usually read & written ( packed )
> into some sort of bit field in 16 or 32 bit words. Caolan what do you
> think?

Today these 'boolean' value are typed as sal_Bool or BOOL, both of
them are unsigned char.

This patch is to prepare the code so that I can as some time do a switch from

typedef sal_Bool BOOL
to
typedef bool BOOL

in solar.h


>
> Noel
>
>