[Libreoffice] Quoting issue in autogen.sh

Jan Holesovsky kendy at suse.cz
Tue Oct 5 00:23:40 PDT 2010


Hi Thomas,

On 2010-10-05 at 01:07 +0200, Thomas Klausner wrote:

> One remaining issue:
> ./autogen.sh --arg=value CFLAGS=foo
> doesn't work with the regex, because it becomes something like:
> ./configure '--arg=value CFLAGS=foo'
> I'm not yet sure how to fix that.

Yesterday I committed a bit different fix [was unable to push thanks to
a PEBKAC problem ;-)], and you already left the IRC to give it to you
for testing; pushed it now:

http://cgit.freedesktop.org/libreoffice/build/commit/?id=d1a42c0a9cb65be32b611a61f300d941220c5d68

The thinking there is that either $old_args, or the args passed on the
command line are used, but never both at the same time thanks to the

if test $# -eq 0 && test -f config.log; then

condition.

Does this work for you?  If not, please feel free to revert it :-)

Thank you,
Kendy



More information about the LibreOffice mailing list