[Libreoffice] [PATCH] Libs-core - Remove redundant #include directives & comments

Kohei Yoshida kyoshida at novell.com
Wed Oct 6 19:58:07 PDT 2010


On Wed, 2010-10-06 at 23:51 +0100, jgraeme wrote:
> On 6 October 2010 08:37, David Tardon <dtardon at redhat.com> wrote:
> > Some really rare stuff in here, like includes from sj2 or so3 :) Pushed.
> 
> Thanks for committing this patch, however when looking at
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=2ff212ff7de4675deeab61a3b68067de30589ff2
> I noticed that unlike the other patches I've submitted I'm not down as
> the author. Just checking to see if this actually matters or not?

Yeah, I think we the commiters should try to be aware that, when
applying patches from someone else we should use --author="...", to
honor the patch submitter.  Better yet, since your patch is generated
with 'git format-patch', we can simply apply it with 'git am' which
automatically apply the correct author information.  I've been using
that command to apply your patches as well as some of the others.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>



More information about the LibreOffice mailing list