[Libreoffice] [LibreOffice][PATCH] Fixes Compiler Warning

Jan Holesovsky kendy at suse.cz
Fri Oct 15 13:18:19 PDT 2010


Hi Kenneth,

On 2010-10-15 at 21:10 +0200, Kenneth Venken wrote:

> Fixes a compiler warning: "suggest parentheses around && within || "
> I also improved the readability of the code a bit.

The change you did silents the warning by doing what the compiler would
do; but is that really what was the intention there?

(aComplexLanguageLB.GetSavedValue() !=
aComplexLanguageLB.GetSelectEntryPos())

is evaluated regardless the aCTLSupportCB.IsChecked() state - is that
intentional, can you please check?

Thank you,
Kendy



More information about the LibreOffice mailing list