[Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE #3
shutdownrunner at gmail.com
Wed Oct 20 09:13:23 PDT 2010
Thanks for spotting the mistakes. I try to review patches before
sending, but will try better next time.
I haven't been able to compile LibreO yet. Had some problems in the past
and still trying to compile it now. It takes ages on a netbook.
BTW, I sometimes use the following script to help me with replacing:
for i in `grep -rle 'DBG_ASSERT' *` ; do sed 's/DBG_ASSERT/OSL_ENSURE/g'
$i > /tmp/modified.txt; mv /tmp/modified.txt $i ; done
Posting for reference should someone find this basic script useful :)
Of course a lot of error messages require DE->EN translation and you
can't make that one automatic.
Dnia 2010-10-20, śro o godzinie 16:10 +0100, Caolán McNamara pisze:
> On Mon, 2010-10-18 at 18:47 +0200, Jacek Wolszczak wrote:
> > Hi,
> > Another patch replacing DBG_ stuff with OSL_ equivalents.
> > Didn't know what to replace
> > http://opengrok.go-oo.org/xref/writer/sw/source/ui/dbui/dbinsdlg.cxx#1190 with.
> I'm swayed towards OSL_ENSURE(false, "message"); for the general case.
> > I am not sure where changes in lines 3838-3857 in my patch come from.
> > Probably result from some changes introduced by other contributors in
> > the meantime. If so, please ignore this part of my patch.
> I just chopped that bit out. And you accidentally removed a neccessary
> "}" along the way, there was one OSl_ENSURE instead of OSL_ENSURE, and
> another little gotcha here and there. Make sure you compile your changes
> and that'll catch those :-)
> Otherwise looks good, committed and pushed. Thanks.
More information about the LibreOffice