[Libreoffice] [PATCH] Fix compilation of icu for VC++ 10

Jesús Corrius jesus at softcatala.org
Mon Oct 25 05:15:01 PDT 2010

On Mon, Oct 25, 2010 at 1:39 PM, Tor Lillqvist <tlillqvist at novell.com> wrote:
> Isn't that wrong? Assuming there are non-Windows platforms where the bundled ICU is used (generic Linux build, other Unixes?), previously that  #include <iostream>  has been used on all of them, but after your change it will be used only on MSVC versions earlier than 10.
> Or is that OK, is the <iostream> functionality actually needed in that source file just for those earlier MSVC versions, but <iostream> has previously been included out of laziness on all platforms?

Yes, the ifdef condition is wrong. I am not sure if the include is
needed in other platforms, but I guess most of them are using a system
icu instead of the old internal one.

Jesús Corrius <jesus at softcatala.org>
Document Foundation founding member
Skype: jcorrius | Twitter: @jcorrius

More information about the LibreOffice mailing list