[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

[Jesús Corrius]

On Sat, Oct 30, 2010 at 10:35 PM, Gert Faller <gertfaller at aliceadsl.fr> wrote:
> OK, thanks.
>
>>
>> Now, this only works when you can compute the length of the string at
>> compile time, i.e. its a string literal, so
>> OUString::createFromAscii("foo") can be trivially replaced, while
>> OUString::createFromAscii(pSomething) should be left alone.
>>
>> C.
>>
>
> Yes, of course, I was just outlining that files must be checked.
>
> And for example in 'writer/sw/source/ui/vba/vbalisthelper.cxx':85, you get
>      msStyleName = rtl::OUString::createFromAscii( WORD_BULLET_GALLERY );
> and at line 43 : static const char WORD_BULLET_GALLERY[] = "WdBullet";
> That's ok too ?

Yes, that can be calculated at compile time too :)

-- 
Jesús Corrius <jesus at softcatala.org>
Document Foundation founding member
Skype: jcorrius | Twitter: @jcorrius