[Libreoffice] [PATCH v2] fontdialog: Convert switch with only 1 case to an if ()

Caolán McNamara caolanm at redhat.com
Tue Sep 28 08:54:18 PDT 2010

On Tue, 2010-09-28 at 17:37 +0200, Sebastian Spaeth wrote:
> This is a switch statement that only ever checks 1 case and has no
> default action, so make it an if().
> Remove some commented out code in the switch while taking the git
> blame anyway.

Looks good, there is the theoretical possibility that the SfxAllItemSet
ctor which used to always get executed, but is now only executed under
that single condition, has some hidden sideeffects which would cause
some knock on. But that's exceedingly unlikely, I'd fire it in.


More information about the LibreOffice mailing list