[Libreoffice] [PATCH] Cleaned up the comments and code in the following files.

Michael Meeks michael.meeks at novell.com
Thu Sep 30 02:58:27 PDT 2010


Hi Nick,

	This is some great work :-) but as cedric says being a bit more
discriminating would be good; ie. if the comment has something useful to
say lets keep just the useful bit:

On Tue, 2010-09-28 at 16:06 -0400, Nick Savage wrote:
> I wasn't sure if this is what I was supposed to be doing, so I only
> did that one folder. I'd like to be helping out LibreOffice any way I
> can!

	Wise - and it's really good to have you on-board.

>  
> -// OD 20.02.2003 #107369# - method to update statics for paint
> +// method to update statics for paint

	excellent :-)

> -    // OD 2004-03-05 #i18143#
>      mbBookPreview = false;
>      mbBookPreviewModeToggled = false;

	Perhaps keeping the issue number - perhaps saving some vspace b
appending it to the next line ?
 
> -/** calculate page preview layout sizes
> -
> -    OD 18.12.2002 #103492#
> -
> -    @author OD
> -*/
>  void SwPagePreviewLayout::_CalcPrevwLayoutSizes()

	Fair enough - we don't need to be told that CalcPrevwLayoutSizes
calculates page preview layout sizes ;-)

> -        // OD 19.02.2003 #107369# - use method <GetRowOfPage(..)>.

	But that has some useful signal amid the noise to keep.

> -/** method to adjust page preview layout to document changes
> -
> -    OD 18.12.2002 #103492#
> -
> -    @author OD
> -*/
>  bool SwPagePreviewLayout::ReInit()

	And the 'method to adjust ...' seems to add something useful
to ::Reinit ?

	Sorry the task was under-clear ? :-) any chance you could tweak the
task description to make it clearer in the wiki ? [ and do you want to
tweak the patch to get it included, or shall I ? ]

	Many thanks,

		Michael.

-- 
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot




More information about the LibreOffice mailing list