[Libreoffice] [PATCHES] [Janitor] Writer accessibility.cxx Cleanup/Bugfix
cedric.bosdonnat.ooo at free.fr
Thu Sep 30 09:26:16 PDT 2010
Many thanks for getting involved in LibreOffice development adventure!
On Thu, 2010-09-30 at 10:54 -0500, Phil Bordelon wrote:
> Here are two patches for Writer/StarMath's accessibility.cxx. (I
> picked a random module and went for the first C++ file I could find
> within.) One patch simply removes a whole bunch of dead code from
> conditionals; the other is actually a minor bugfix, wherein someone
> commented out a null-pointer check where they almost certainly just
> meant to remove a refcounter.
It seems Ok for me.
> I was wondering just how broad this patches should be; I have one that
> removes a lot more dead code from accessibility.cxx, but should it also
> do the same to the .hxx? Other files at the same time?
Do as you like!
> These patches are released under the GPLv3+, if that's relevant for
> something so basic.
Thanks for your patches, but we can't integrate them unless you accept
to release them under the LGPLv3+.
More information about the LibreOffice