[Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts
tlillqvist at novell.com
Fri Apr 1 01:00:51 PDT 2011
> I have improved my last patch for the Color Charts.
Thanks! I will commit it, just a question about one thing I don't understand:
#define RID_SVXPAGE_ASIAN_LAYOUT (RID_SVX_START + 246)
#define RID_OPTPAGE_CHART_DEFCOLORS (RID_SVX_START + 299)
+#define RID_OPTQB_COLOR_CHART_DELETE (RID_SVX_START + 296)
+#define RID_OPTSTR_COLOR_CHART_DELETE (RID_SVX_START + 289)
#define RID_SVXPAGE_COLORCONFIG (RID_SVX_START + 249)
#define RID_SVXQB_DELETE_COLOR_CONFIG (RID_SVX_START + 324)
Did you just choose these values manually, checking that they don't overlap with any existing one? Or is there some mechanism to do it that is guaranteed to get an unused number? Are these assignments listen in numerical order somewhere? (But why did you not then add your new numbers to that list, too?) Sorry if this is a stupid question...
More information about the LibreOffice