[Libreoffice] Is a mutex guard preferable?

Takeshi Abe tabe at fixedpoint.jp
Fri Apr 8 16:49:00 PDT 2011


Hi Michael,

Thanks for your confirmation!

On Fri, 08 Apr 2011 16:56:58 +0100, Michael Meeks <michael.meeks at novell.com> wrote:
> Hi Takeshi,
> 
> On Thu, 2011-04-07 at 21:35 +0900, Takeshi Abe wrote:
>> I just wonder if a mutex guard should protect the whole body of
>> SmGraphicAccessible::setCaretPosition() in starmath/source/accessibility.cxx
>> as attached.
> 
> 	Yes - good catch :-) everyone else that calls
> 
>     String aTxt( GetAccessibleText_Impl() );
> 
> 	takes one - so ... I'm sure we should here :-)
> 
>> Any suggestion will be appreciated.
> 
> 	Please do commit such fixes to libreoffice-3-4 and they'll end up on
> master :-)
Done.

Cheers,
-- Takeshi Abe


More information about the LibreOffice mailing list