[Libreoffice] dbgmacros.hxx / dbgmacros.cxx

Christina Roßmanith ChrRossmanith at web.de
Sat Apr 9 14:08:56 PDT 2011

Am 05.04.2011 10:50, schrieb Noel Power:
> Hi Christina
> \On 05/04/11 09:11, Christina Roßmanith wrote:
>> Hi,
>> after removal of comments it becomes clear that DbgAssert() is empty. 
>> It is used for the definition of PRE_CONDITION (unused), 
>> POST_CONDITION (used in classfactory.cxx and propertyhdl.cxx) and 
>> ENSURE (used at several places).
>> I think PRE_CONDITION, POST_CONDITION and ENSURE can be removed from 
>> the code and afterwards dbgmacros.{cxx,hxx} can be removed from the 
>> code base. Should the macros be replaced by some more recent macros?
> the OSL_XXXX equivalent macros probably are a suitable replacement(s), 
> see http://opengrok.libreoffice.org/xref/ure/sal/inc/osl/diagnose.h#53
> Noel
So I'll remove the definition of PRE_CONDITION and POST_CONDITION and 
replace the latter with OSL_POSTCOND (the former isn't used). ENSURE 
will be replaced by OSL_ENSURE and DbgAssert removed. Any objections?


More information about the LibreOffice mailing list