[Libreoffice] [PATCH] gitattributes .po filter performance problem

Andras Timar timar74 at gmail.com
Tue Apr 12 01:37:26 PDT 2011


2011/4/12 Miklos Vajna <vmiklos at frugalware.org>:
> On Mon, Apr 11, 2011 at 08:29:13PM +0200, Andras Timar <timar74 at gmail.com> wrote:
>> Hi,
>>
>> Some of us experienced performance problems with the gitattributes
>> filter defined for .po files. The 'clean' filter were not only run on
>> commit, but also during clone/pull. This was not intended at all.
>> Miklos asked about it on git mailing list, if it was a bug in git. See
>> all details in this thread:
>> http://marc.info/?t=130251154100001&r=1&w=2
>>
>> On git list we were recommended to use hook instead of filter. Please
>> review my patch. If you apply it, don't forget to remove po filter
>> lines from your git config.
>
> Looks OK. Kendy, does it sound acceptable for you as well?
>
Amended patch, git add $file is necessary after the conversion.
(Thanks for the hint Miklos).

Andras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-use-git-hook-instead-of-gitattributes-filter-for-.po.patch
Type: text/x-diff
Size: 1738 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110412/09b36265/attachment.patch>


More information about the LibreOffice mailing list