[Libreoffice] [PUSHED] [PATCHES] Fixed some CLang++ errors/warnings in sal

Thorsten Behrens thb at documentfoundation.org
Thu Apr 14 03:33:26 PDT 2011

Julien Chaffraix wrote:
> Subject: [PATCH 1/5] Added error handling for pthread_mutexattr_settype.
Handled slightly different, to avoid duplication & retain the
pthread_mutexattr_destroy call.

> Subject: [PATCH 2/5] Added handling for the write errors in receiveFdPipe.
Applied - would you want to look into the TODO case as well? A rather 
nasty cause for errors ...

> Subject: [PATCH 3/5] Fixed a potential null-dereferencing error in osl_closeProfile
> Subject: [PATCH 4/5] Fixed some false positives 'dead assignments' seen in CLang++
> Subject: [PATCH 5/5] No need to check out execv return value.
Applied - the extra ifs in 4/5 are a lesser evil than those warns, I

Many thanks for your fixes - pushed to the -3-4 branch, you're
fixing real bugs here.


-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110414/db4d3f8b/attachment.pgp>

More information about the LibreOffice mailing list