[Libreoffice] [PATCH] sal_{Bool, True, False} to bool, true, false.
Thorsten Behrens
thb at documentfoundation.org
Thu Apr 14 04:01:37 PDT 2011
Kayo Hamid wrote:
> Hello, I asked at #libreoffice-dev if we have to see some special
> condition to change sal_Bool to bool and so on, unanswered.
>
> @@ -69,10 +69,10 @@ using namespace ::com::sun::star;
> struct ImplColorListData
> {
> Color aColor;
> - sal_Bool bColor;
> + bool bColor;
>
> - ImplColorListData() : aColor( COL_BLACK ) { bColor = sal_False; }
> - ImplColorListData( const Color& rColor ) : aColor( rColor ) { bColor = sal_True; }
> + ImplColorListData() : aColor( COL_BLACK ) { bColor = false; }
> + ImplColorListData( const Color& rColor ) : aColor( rColor ) { bColor = true; }
> };
>
Hi Kayo,
the above change is clearly useful - an internal bool, not
used/exposed elsewhere.
> - EnableUserDraw( sal_True );
> + EnableUserDraw( true );
>
etc. - not sure if we really want to manually hunt all those down -
I suggest to go for one of the other easy hacks (this one is not
listed there FWICT), until we have a clear plan here.
Cheers,
-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110414/3593ae9a/attachment.pgp>
More information about the LibreOffice
mailing list