[Libreoffice] [Partly pushed] Easy Hack completed - All bogus comments removed

Cedric Bosdonnat cedric.bosdonnat.ooo at free.fr
Fri Apr 15 01:48:21 PDT 2011


Hi Julio,

Many thanks for your patches nice patches. I think we'll manage to
eradicate loads of useless comments this way ;)

I pushed both patches in libs-gui and libs-core after some manual edits,
but it takes too much time to manually adjust the patch for sw. Could
you please adjust your regexps to fix the following problems:
  * comments indentation is reduced to 4 spaces in all cases: you should
keep the number of existing leading spaces to avoid breaking the
indentation
  * #b[0-9]\+# comments should be purely removed: we don't need them as
they refer to some Oracle internal bug database. Please pay attention
here ase you may have #b...# and #i....# references on the same line
  * you often have some comment after the bug number, please keep them.
Some could be removed, but not all.
  * While at it, could you remove the lines with comments like '// <--'
as those are the "closing" comments for the other silly SCM-like
comments?

Don't forget to check your patch after running your regexps as you may
have other unexpected cases.

Regards,

On Thu, 2011-04-14 at 19:26 -0300, Júlio Hoffimann wrote:
> I forget to mention...
> 
> 
> This patch is under the LGPLv3+ / MPL license.
> 
> 2011/4/14 Júlio Hoffimann <julio.hoffimann at gmail.com>
>         ... and the last and big one. ;-)
>         
>         
>         https://bugs.freedesktop.org/show_bug.cgi?id=36234
>         
>         
>         Regards,
>         Júlio.
>         
>         
> 
> 
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr



More information about the LibreOffice mailing list