[Libreoffice] [LibreOffice] [PATCH] [GSOC 2011] Hack: Store/Restore font dropdown MRU

Cedric Bosdonnat cedric.bosdonnat.ooo at free.fr
Fri Apr 15 02:10:37 PDT 2011


Hi Marco,

On Thu, 2011-04-14 at 19:12 +0100, Caolán McNamara wrote:
> On Thu, 2011-04-14 at 19:07 +0200, Marco wrote:
> > Hi all,
> > "Store/Restore font dropdown MRU" is the required hack I worked on.
> > I attached the related patch.
> 
> oh cool, one little thing, I wouldn't bother with using the
> osl_getThreadTextEncoding() (which is just the system encoding) and
> instead just use RTL_TEXTENCODING_UTF8, that way we don't run into
> problems munging e.g. CJK font names into "?????" if the system text
> encoding is some 8bit foo.

I just pushed your patch after:
  * Applying Caolan's comment
  * Adding #if OSL_DEBUG_LEVEL > 1 around the include of cstdio

Many thanks for your nice patch and welcome to the LibreOffice hacking
community!

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr



More information about the LibreOffice mailing list