[Libreoffice] [Partly pushed] Easy Hack completed - All bogus comments removed

Júlio Hoffimann julio.hoffimann at gmail.com
Sat Apr 16 13:09:28 PDT 2011


Hi Cédric,

I'm doing it task by task. This patches removes all bug id's from Oracle
internal database keeping the indentation, you could apply it, even with the
lines which the content is "//" "- loop prevention" or "- optimization",
i'll fix it in the next patch. ;-)

Under the LGPLv3+ / MPL license.

Regards,
Júlio.

2011/4/15 Júlio Hoffimann <julio.hoffimann at gmail.com>

> Ok Cedric, no problem. I will fix these problems.
>
> Thank you for return.
>
> Regards,
> Júlio.
>
>
> 2011/4/15 Cedric Bosdonnat <cedric.bosdonnat.ooo at free.fr>
>
>> Hi Julio,
>>
>> Many thanks for your patches nice patches. I think we'll manage to
>> eradicate loads of useless comments this way ;)
>>
>> I pushed both patches in libs-gui and libs-core after some manual edits,
>> but it takes too much time to manually adjust the patch for sw. Could
>> you please adjust your regexps to fix the following problems:
>>  * comments indentation is reduced to 4 spaces in all cases: you should
>> keep the number of existing leading spaces to avoid breaking the
>> indentation
>>  * #b[0-9]\+# comments should be purely removed: we don't need them as
>> they refer to some Oracle internal bug database. Please pay attention
>> here ase you may have #b...# and #i....# references on the same line
>>  * you often have some comment after the bug number, please keep them.
>> Some could be removed, but not all.
>>  * While at it, could you remove the lines with comments like '// <--'
>> as those are the "closing" comments for the other silly SCM-like
>> comments?
>>
>> Don't forget to check your patch after running your regexps as you may
>> have other unexpected cases.
>>
>> Regards,
>>
>> On Thu, 2011-04-14 at 19:26 -0300, Júlio Hoffimann wrote:
>> > I forget to mention...
>> >
>> >
>> > This patch is under the LGPLv3+ / MPL license.
>> >
>> > 2011/4/14 Júlio Hoffimann <julio.hoffimann at gmail.com>
>> >         ... and the last and big one. ;-)
>> >
>> >
>> >         https://bugs.freedesktop.org/show_bug.cgi?id=36234
>> >
>> >
>> >         Regards,
>> >         Júlio.
>> >
>> >
>> >
>> >
>> > _______________________________________________
>> > LibreOffice mailing list
>> > LibreOffice at lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>> --
>> Cédric Bosdonnat
>> LibreOffice hacker
>> http://documentfoundation.org
>> OOo Eclipse Integration developer
>> http://cedric.bosdonnat.free.fr
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110416/33ce8b56/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bug-id-s-from-Oracle-internal-database-rem.libs-core.patch
Type: text/x-patch
Size: 2008 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110416/33ce8b56/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bug-id-s-from-Oracle-internal-database-remo.libs-gui.patch
Type: text/x-patch
Size: 2553 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110416/33ce8b56/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bug-id-s-from-Oracle-internal-database-remove.writer.patch
Type: text/x-patch
Size: 33824 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110416/33ce8b56/attachment-0005.bin>


More information about the LibreOffice mailing list