[Libreoffice] [PUSHED] [PATCHES] Fixed some CLang++ errors/warnings in sal

Julien Chaffraix julien.chaffraix at gmail.com
Sun Apr 17 23:48:27 PDT 2011


>> Applied - would you want to look into the TODO case as well? A rather
>> nasty cause for errors ...
>
> While it is theoretically possible to hit this, I doubt in practice
> that writing an int to a file descriptor will ever do a partial write.
> It may just be better to change that to an OSL_ASSERT instead of
> adding a for loop. Thoughts?

I just went ahead and fixed the root cause of the bug instead of using
an assertion. While at it, I fixed another error in the same file.

The patch is released under the dual LGPLv3 (or later) / MPL license.

Thanks,
Julien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixed-write-2-usage-in-process.c.patch
Type: text/x-patch
Size: 2667 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110417/a1e43a15/attachment.bin>


More information about the LibreOffice mailing list