[Libreoffice] [PUSHED] Re: [PATCH] fixes for some cppcheck warnings

Caolán McNamara caolanm at redhat.com
Mon Apr 18 13:30:31 PDT 2011


On Fri, 2011-04-15 at 16:32 -0300, Kayo Hamid wrote:
> On Fri, 15 Apr 2011 16:25:32 -0300, Kayo Hamid 
>  <kayo.hamid at gekkolinux.com.br> wrote:
> > Just variableScope, sending for review.

pushed, thanks for this. Poking at this area, the DWORD err is unused,
but the typical pattern elsewhere is to call ImplWriteLastError on these
"ignored" errors so that they can be at least logged for debugging. So I
added that change as well.

C.



More information about the LibreOffice mailing list