[Libreoffice] [PATCH][PUSHED] Fix cppcheck warnings in components (easy hack)

Katarina Machalkova kmachalkova at suse.cz
Thu Apr 28 05:08:02 PDT 2011

> The attached patch fixes lots of cppcheck warnings in the components
> repository.

Thanks! All of those are good points.

Just small nitpicking (cui/source/dialogs/thesdlg.cxx) -- I did the following 
change to your patch:

-            (aLookUpHistory.empty() == 0 || aLookUpText != 
 +           (aLookUpHistory.empty() || aLookUpText != aLookUpHistory.top()))

ie. it is OK to use just empty(), as aLookUpHistory is std::stack and this 
call returns bool. No need to additionally compare it to zero.

> By the way, did anybody review my latest pyuno patch update? Or am I not
> patient enough :)

Nope, or so it seems. As a person in charge of integrating patches this week, 
I didn't spot it, because I usually look for [PATCH] keyword in e-mail 
subject. Sorry about that. Someone speaking Python will have look at it in due 

Keep up good work! :)

  \\\\\              Katarina Machalkova    
  \\\\\\\__o          LibO developer
__\\\\\\\'/_          & hedgehog painter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110428/8d59d4a0/attachment.pgp>

More information about the LibreOffice mailing list