[Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell

Noel Power nopower at novell.com
Tue Aug 2 02:07:22 PDT 2011

Hi Miklos
On 01/08/11 19:26, Miklos Vajna wrote:
> Hello Noel,
> I recently tested the copy&paste export (using RTF) on master and got a
> crash. The attached patch solves the issue here.
> OK to push, or you want to add a check in the called SwMSConvertControls
> constructor?
actually I am not at all familiar with the export side of this stuff. In 
theory I think your check is ok ( unfortunately I would guess the 
expectation that the doc shell is valid is probably buried deep in the 
SvxMSDffManager implementation ( where it probably isn't checked either ) )

but... I wonder why the doc shell isn't set up in the case of the RTF 
export ( is this something expected )  will this screw up other things 
later on.  Also for the case above is the control export something that 
is relevant for the RTF filter even ?

sorry haven't helped much :-(


More information about the LibreOffice mailing list