[Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

Kohei Yoshida kohei.yoshida at suse.com
Thu Aug 4 15:57:11 PDT 2011

On Fri, 2011-08-05 at 00:29 +0200, Maciej Rumianowski wrote:
> Dnia 2011-08-04, czw o godzinie 23:23 +0200, Maciej Rumianowski pisze:
> > Okay so I will work further on SvULongs, there is some in libs-gui,
> > and
> > than come back to writer. 
> Sorry, I meant libs-core.
> If I see any sal_Bool (sal_True, sal_False), should I change it to
> standard bool?

Absolutely!  *But* take at least a cursory look to make sure that it is
really used as a boolean value.  sal_Bool is a typedef to an 8-bit
integer, and some code does abuse this fact and use it more like an
enum.  You probably don't see very many uses of such abuse, but they are
there in some corners.


Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida at suse.com>

More information about the LibreOffice mailing list