[Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

Maciej Rumianowski maciej.rumianowski at gmail.com
Sun Aug 7 08:04:49 PDT 2011

Hi Eike,

Dnia 2011-08-07, nie o godzinie 11:17 +0200, Eike Rathke pisze:
> You're right, the code is "suboptimal" ... in fact IsRemoved_Impl()
> and
> IsAdded_Impl() could also return the index of the element found so it
> wouldn't be needed to be searched again. Want to take care of it? 

Yes :) My proposition of new declaration

> bool IsAdded_Impl( size_t nKey, size_t* nFoundKey );

I am attaching corrected patch, without this change and without size_t.
I have casted variables to size_t, in next patch I will try to change short to appropriate type and in other places try to use size_t.

Best Regards,

More information about the LibreOffice mailing list