[Libreoffice] [REVIEW] fix for fdo#37319: don't write invalid references to odf files

Eike Rathke ooo at erack.de
Tue Aug 9 06:33:36 PDT 2011

Hi Markus,

On Tuesday, 2011-08-09 05:04:35 +0200, Markus Mohrhard wrote:

> this patch removes entries like #REF! A1:A3 for named ranges when the sheet
> referenced by the named range is no longer there.

I didn't check lately, is the current compiler's ODFF grammar able to
read a [#REF!] properly?

> @@ -3808,7 +3816,18 @@ void ScXMLExport::WriteNamedExpressions(const com::sun::star::uno::Reference <co
>          }
>          else
>          {
> -            AddAttribute(XML_NAMESPACE_TABLE, XML_EXPRESSION, sOUTempContent);
> +            ScRange aRange;
> +            if (pNamedRange->GetErrCode() || !pNamedRange->IsValidReference(aRange))

Sure that on any error of pNamedRange->GetErrCode() a [#REF!] should be
written? This look dubious to me.


 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110809/c12f85b4/attachment.pgp>

More information about the LibreOffice mailing list