[Libreoffice] [REVIEW] Fix incorrect import of multi-range data source in chart

Kohei Yoshida kohei.yoshida at suse.com
Tue Aug 9 19:18:20 PDT 2011


I'd like to backport the attached patch to the 3-4 branch.

Without this patch, import of charts in Excel documents fail when the
data series consist of multiple cell ranges, which is common in complex
chart objects.  The failure happens only in locales where the function
and range separator is ',' (Tools - Options - Calc - Formula -
Separators - Function), which is default in the English locales and
others.

I've attached a very small example document to demonstrate the failed
chart import, which is amazingly smaller than the patch itself when
compressed. ;-)

Anyway, review and sign-off very much appreciated.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida at suse.com>


More information about the LibreOffice mailing list