[Libreoffice] [PATCH] fix xml2cmp build with svn gcc

Tom Tromey tromey at redhat.com
Wed Aug 10 09:20:25 PDT 2011


I tried building LibreOffice with svn trunk gcc.

It dies in xml2cmp with:

Compiling: xml2cmp/source/xcd/xmlelem.cxx
In file included from ./xmlelem.hxx:38:0,
                 from /home/tromey/Space/LibreOffice/bootstrap/clone/ure/xml2cmp/source/xcd/xmlelem.cxx:30:
./../support/list.hxx: In instantiation of 'void DynamicList<XY>::insert(unsigned int, XY* const&) [with XY = XmlElement]':
/home/tromey/Space/LibreOffice/bootstrap/clone/ure/xml2cmp/source/xcd/xmlelem.cxx:263:1:   required from here
./../support/list.hxx:229:5: error: 'checkSize' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
./../support/list.hxx:229:5: note: declarations in dependent base 'List<XmlElement*>' are not found by unqualified lookup
./../support/list.hxx:229:5: note: use 'this->checkSize' instead
dmake:  Error code 1, while making '../../unxlngx6.pro/obj/xmlelem.obj'


The appended patch fixes this problem by adding a 'this->' qualifier.

This is contributed under the LGPLv3+/MPL.

Tom

diff --git a/xml2cmp/source/support/list.hxx b/xml2cmp/source/support/list.hxx
index 6de123e..e4e5361 100644
--- a/xml2cmp/source/support/list.hxx
+++ b/xml2cmp/source/support/list.hxx
@@ -226,7 +226,7 @@ DynamicList<XY>::insert(unsigned pos, XY * const & elem_)
     if ( pos > this->len )
       return;
 
-    checkSize(this->len+2);
+    this->checkSize(this->len+2);
     memmove(this->inhalt[pos+1], this->inhalt[pos], (this->len-pos) * sizeof(XY*) );
     this->inhalt[pos] = elem_;
     this->len++;


More information about the LibreOffice mailing list