[Libreoffice] [PUSHED] [PATCH] SAL_ALLOW_LINKOO_SYMLINKS, libreoffice-3-4 sal module with dbglevel=2: init test fails

[Lionel Elie Mamane]

On Mon, Aug 08, 2011 at 01:11:43PM +0100, Caolán McNamara wrote:
> On Sun, 2011-08-07 at 11:32 +0200, Lionel Elie Mamane wrote:

>> Ah, I found:
>> solenv/bin/linkoo:export SAL_ALLOW_LINKOO_SYMLINKS=1
>> sc/source/ui/vba/testvba/runTests.pl: $ENV{"SAL_ALLOW_LINKOO_SYMLINKS"} = "1";
>> toolkit/workben/layout/TEST:export SAL_ALLOW_LINKOO_SYMLINKS=1

>>> I worked around this at
>>> http://cgit.freedesktop.org/libreoffice/ure/commit/?id=784641a19811c22208e7db8efa150e744348d8bf
>>> in master.

>>> Don't know, in the light of that, if we still need this proposed patch
>>> then ?

>> Your workaround unsets that variable for the test, effectively saying
>> that the "else" branch above should not be tested at all. From a
>> general point of view, this looks fishy; if a specific subtest does
>> not apply to this branch, I'd rather disable just that specific
>> subtest; I mean the file sal/qa/osl/file/osl_old_test_file.cxx tests
>> for the SAL_ALLOW_LINKOO_SYMLINKS environment variable, and if it is
>> set, runs only the subtests that should pass. For example, in

> The thing is that SAL_ALLOW_LINKOO_SYMLINKS is a foul and monstrous
> hack to get make dev-install work in the sense that rebuilding a
> module will make the installed install-set at "install" use the
> newly rebuilt libraries without re-installing the install set (...)x

You mean I can just run "build" in a module and
./install/program/soffice will use it, without rerunning "make
dev-install"? Ah yes, it works, you just increased my productivity!
Thanks.

-- 
Lionel