[Libreoffice] [PATCH][PUSHED]cppcheck detects division by 0 in sw/source/ui/vba/vbarows.cxx

[Julien Nabet]

Le 15/08/2011 11:19, Noel Power a écrit :
> On 13/08/11 09:38, Julien Nabet wrote:
>> Hello,
>>
>> cppcheck detects division by 0 in sw/source/ui/vba/vbarows.cxx, line 266
>> I discussed this with Norbert on IRC, here what we propose to add 
>> before this line :
>>
>> if ((nNewWidth <= 0) || (nWidth <= 0))
>> {
>> OSL_ASSERT(!((nNewWidth <= 0) || (nWidth <= 0)));
>>        return;
>> }
> might be better to just throw a RuntimeException here
>>
>> Is this add ok ? (if yes, I can commit and push it on master).
> sure, I would say go for it
>
> Noel
Ok, I commited and pushed on master
+    if ((nNewWidth <= 0) || (nWidth <= 0))
+    {
+        throw new RuntimeException("Pb with width, in 
SwVbaRows::setIndentWithAdjustProportional (nNewWidth <= 0) || (nWidth 
<= 0)");
+    }

Thank you.

Julien.