[Libreoffice] [PATCH] Enable CUPS unconditionally

Francois Tigeot ftigeot at wolfpond.org
Mon Aug 22 11:25:11 PDT 2011

On Mon, Aug 22, 2011 at 07:20:24PM +0200, Rene Engelhard wrote:
> On Mon, Aug 22, 2011 at 08:29:12AM +0200, Francois Tigeot wrote:
> > On Sun, Aug 21, 2011 at 10:50:43PM +0200, Rene Engelhard wrote:
> > > On Sun, Aug 21, 2011 at 08:53:14PM +0200, Francois Tigeot wrote:
> > 
> > Right, I may have been too enthusiastic about this. Would a reduced test like
> > this be acceptable ?:
> > 
> > dnl check for cups support
> > dnl ===================================================================
> > AC_MSG_CHECKING([whether native cups support is present])
> Just "for cups" is enough.

I've removed the "native" bit in the new attached patch.
This code was already there; I've no idea what the original author meant by
"native" cups.

> > AC_CHECK_LIB(cups, cupsPrintFiles)
> I noticed that in your initial patch, too.
> Do we link against cups now? Did that change?

This is also what is currently in the tree.
AFAIK, libcups is not linked at build time and I have no idea why the check
was there in the first place.
Howewer, it is my intention to make the print code link with cups normally,
in which case it is better for this check to stay.

If nobody objects, I'll push the patch in a short while.

Francois Tigeot

More information about the LibreOffice mailing list