[Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

Eike Rathke ooo at erack.de
Tue Aug 23 17:09:13 PDT 2011


Hi Markus,

On Wednesday, 2011-08-17 14:14:18 +0200, Eike Rathke wrote:

> > > Apparently the FormulaToken used is not a FormulaIndexToken.
> > 
> > Oh. I should not only override SetByte but also SetIndex. In calc all
> > formula tokens are derived from ScToken which is derived from FormulaToken
> > and not from FormulaIndexToken. I should no longer finish patchs after
> > learning.c
> [...]
> Actually the new ScNameToken implemented would belong to formula/*
> instead, but there is already FormulaIndexToken, which also now has
> changes for local/global names, so ScNameToken is superfluous and can be
> removed. ScRawToken::CreateToken() needs to be changed back to return
> a FormulaIndexToken.

I did the necessary changes in
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fcac4e3eb4df6dcd4d6f6955a5d369262bcd1ea4

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110824/1c697ed0/attachment-0001.pgp>


More information about the LibreOffice mailing list