[Libreoffice] [PUSHED][PATCH] Remove unnecessary parameter to IDocumentStatistics::UpdateDocStat

Caolán McNamara caolanm at redhat.com
Wed Aug 24 03:50:02 PDT 2011

On Wed, 2011-08-24 at 00:30 +0200, Miklos Vajna wrote:
> On Tue, Aug 23, 2011 at 04:41:59PM +0100, Caolán McNamara <caolanm at redhat.com> wrote:
> > d) I'm not sure there's any good reason to set the DocStat in the
> > (current) rtf filter.
> You mean something like this? Given that the idl says these properties
> are readonly (I did not notice that so far), I don't think there is a
> reason to set them.

I was thinking more of the "old" rtf filter which const casts away
constness to set these on import. Need better names than old/new.

re: readonly-ness in the uno api, the AdvancedTextDocument
CharacterCount etc properties are read-only alright, but no mention is
made of readonly-ness for DocumentStatistics from XDocumentProperties

I suppose there's a counter-argument that says setting what the
producing app thinks was the stats allows the expected results from
fields etc up to as far as the first update when the user edits that

six of one, half a dozen of the other I guess.


More information about the LibreOffice mailing list