[Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

[Eike Rathke]

Hi Michael,

On Wednesday, 2011-08-24 12:54:14 +0100, Michael Meeks wrote:

> On Wed, 2011-08-24 at 11:07 +0200, Markus Mohrhard wrote:
> > But do you know if there is a reason except oox that the
> > FormulaCompiler and the FormulaTokens are not in calc?
> 
> 	IMHO this was a highly retrograde step that was taken. There is / was
> no real problem with having a single formula compiler, in one place that
> can parse lots of different types of formulae.

See my previous mail, the actual reason to factor it out was the report
designer wanted to use the formula wizard.

> 	It would be far more efficient and sensible IMHO to simply pass the
> incoming formula as strings over to the core: what we used to do before
> the brave-new-re-write to use masses of UNO ;-)

Yes and no.. simpler and more efficient yes, though the UNO filter
approach could be used for other formula languages as well. Not that
I do foresee some in the near future, but..

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110824/c532596b/attachment.pgp>