[Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

[Marco]

On Tue, 30 Aug 2011 09:36:00 +0200, Thorsten Behrens  
<thb at documentfoundation.org> wrote:

> Marco wrote:

skip
>
>> Well, I understand this one and your other comments, but I think you  
>> should
>> take into account that all the script is embedded into the svg document.
>> If a user incurs into a problem with the animation engine and mail  
>> his/her
>> document to us we can get immediately which script release is.
>>
> Good point - but then let's auto-generate that number, otherwise
> incrementing it will be forgotten every once in a while.

Uhm, so the new number will be more a built number than a version number.
Maybe it would be better to replace it with a full time stamp related to
the last time the JavaScript code file was changed.


>> Again, the script and its legal notice are embedded into a svg
>> document, so it seems that it is meaningless the fragment
>> "OR THIS FILE HEADER". As far as the fact I didn't point out that
>> in the commit notice, well it didn't seem to me a so big change
>> (moreover I did not modified the legal notice itself).
>>
> Meaningless or not, legal notices (which is all of the header)
> cannot be changed, except by the copyright holder.

Ok sorry, I have no knowledge of software legal issues.
So should I remove such a change ?

>> From my point of view the C++ header is not anymore the right
>> place where to look for JavaScript presentation engine changes.
>> I think that the best solution is to include into the commit the
>> JavaScript code file itself (and the python script too).
>>
> Absolutely! Let's then get rid of the svgscript.hxx entirely, and
> generate that during build time, with your script - that also gives
> the nice option to plug in the version number you mentioned above
> from git.

Yep, I was thinking of that by a while, what stopped me from
deploying such a solution is: - it is not clear to me how to get
the python script executed automatically (make file ?);
- it does not seem that python is listed between the requirements
to get LibreOffice built.


Cheers,
-- Marco


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/