[Libreoffice] [PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack< ScChangeTrackMsgInfo* >

Eike Rathke erack at redhat.com
Mon Dec 5 09:26:30 PST 2011

Hi Marcel,

On Thursday, 2011-12-01 11:08:40 +0100, Marcel Metz wrote:

> this is my first patch series to the lo project. It replaces the use
> of the tools Stack class and corresponding macros with the std::stack
> as suggested in in bug #39445 [1] (an easy hack).

As already mentioned on IRC on Friday, one thing that's missing is all
replacements in the code of the binfilter repository, when reworking the
entire code base that needs to be included in the build to catch things,
here specifically the class Stack that will be gone now. The binfilter
is in large pieces a snapshot of the code, but some low level modules
are shared and not duplicated, as unfortunately here is the case with
module tools. Note that to catch all places before building you best
remove solver/$INPATH/inc/tools/stack.hxx and then
rm binfilter/$INPATH/misc/*.dp*
to remove the old dependency files the compiler would complain about
because of the removed stack.hxx not found.

Would be great if you could complete the work on binfilter.

However, I promised you some remarks about some caressing I did with
your patch, they'll arrive shortly as a separate mail :-)

> I would like to continue with cleaning up the tools module. I've seen
> that there are other containers in tools like a Table which probably
> could be replaced in most places with a std::table or a std::vector

Yes, but there is no ::std::table, ::std::map would be appropriate to
lookup a key and obtain a corresponding value.

> and the List that could be replaced with std::vector.

Yes. Some work has already been done on that, there might be something

> Should I set up a new Bug for that or can I just hack on if there
> aren't any objections on these changes?

Hack on :-)

Especially for these tools' container types there's already

> [1] https://bugs.freedesktop.org/show_bug.cgi?id=39445#c1

Thanks for the pointer, originally that bug was about something
different, I added a pointer there to the other bug.


LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111205/1449ab7c/attachment.pgp>

More information about the LibreOffice mailing list