[Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack< SmNode* >

Eike Rathke erack at redhat.com
Wed Dec 7 05:34:02 PST 2011


On Wednesday, 2011-12-07 00:28:11 +0100, Stephan Bergmann wrote:

> i.e., at SmNode *pNode = m_aNodeStack.top() in
> SmParser::Expression(), where m_aNodeStack is empty.  It *looks* to
> me that the following happens:  The stack is rightfully empty, but
> the old implementation of tools' stack Pop() always returned null in
> that case, and the code in SmParser::Expression() relies on that --

> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=b419bb21a76c48dda9f9a6ef6182b98e03358176>
> lets the test succeed, but who knows which other code depended on
> this magnificent misfeature of the old stack implementation, too...

I'm inspecting that and will fix.


LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111207/bb9a35c5/attachment.pgp>

More information about the LibreOffice mailing list