[Libreoffice] [Patch] Code review fix

Jan Holesovsky kendy at suse.cz
Fri Dec 9 16:21:13 PST 2011

Hi Muthu,

On 2011-12-05 at 18:06 +0530, Muthu Subramanian K wrote:

> Ah...that didn't strike me...because I assumed it is
> again converted back to 8bit by shifting back...which is the case as
> well in some functions e.g. GetColor()...but then it doesn't seem to
> matter so much as much as for up-sampling.
> Thank you for the clarifications.
> Yes, 65535/255 or 0xFFFF/0xFF might help.

Why shifting right to convert to 8bit is the right inverse operation:

a*257 == (a << 8) + a

Ie. - you are just throwing away the additional "+a" that you've
introduced to fill the color space nicely.


More information about the LibreOffice mailing list