[Libreoffice] [PUSHED][PATCH] Fix for fdo43460, Part III, getLength to isEmpty

Ivan Timofeev timofeev.i.s at gmail.com
Sat Dec 10 09:24:15 PST 2011


10.12.2011 20:34, Olivier Hallot пишет:
> Please find attached a partial fix for Easy Hack FDO43460,
>
> Part III
> Module basic

Pushed, thank you! :)

May I suggest you to remove unnecessary parentheses in addition? i.e

	sal_Bool bOldPassword = ( !OldPassword.isEmpty() );

can be

	sal_Bool bOldPassword = !OldPassword.isEmpty();

and thus more readable (at least to me) :)

Regards,
Ivan


More information about the LibreOffice mailing list