[Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map

Ivan Timofeev timofeev.i.s at gmail.com
Mon Dec 12 08:10:48 PST 2011


12.12.2011 20:05, Caolán McNamara пишет:
> On Sat, 2011-12-10 at 19:23 +0100, Marcel Metz wrote:
>> Hello lo-devs,
>>
>> This patch series replaces some DECLARE_TABLE macros with
>> the std::map equivalent.
>
> Looks good to me. Thanks for this, pushed now.

Hmm... looking at this I think that

- else if ( !mpData->maKeyTable.Insert( nCode, pEntry ) )
+ else if ( mpData->maKeyMap.insert( std::make_pair( nCode, pEntry ) 
).second )

must be

- else if ( !mpData->maKeyTable.Insert( nCode, pEntry ) )
+ else if ( !mpData->maKeyMap.insert( std::make_pair( nCode, pEntry ) 
).second )

i.e. ! is missed in replacement.

Regards,
Ivan


More information about the LibreOffice mailing list