[Libreoffice] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency

Thorsten Behrens thb at documentfoundation.org
Fri Dec 16 00:33:05 PST 2011


Michael Meeks wrote:
> 	Great; I did the same git grep and it seems it's only fiddle with on
> writing so we should get it in :-)
> 
Sigh, well, that writing had a bug - Moggi's password.ods unit test
uncovered, that we write out inconsistent compression mode values in
that case. This is fixed on master with
 f9128f9848de25d80bb032b872f03839f6a3b467

I'll be putting that to -3-5 in a minute - for -3-4, unfortunately,
3.4.5 RC1 does not read password-protected odf documents, so the
previous fix needs to be reverted, and replaced with a cherry-pick
of d0ac36dd66664e3d6953de8b3bdd79eeed8d2e70

I'd probably not want f9128f9848de25d80bb032b872f03839f6a3b467 on
-3-4, we need to support reading those flawed files anyway.

Sorry for the mess,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111216/4cbf693e/attachment.pgp>


More information about the LibreOffice mailing list