[Libreoffice] [PATCH] building with gcc-trunk

[Lubos Lunak]

On Friday 16 of December 2011, Matúš Kukan wrote:
> Hi,
>
> The build was not successful, there is problem in
> testtools/source/bridgetest but
> I created two patches. First is because of new c++ feature but I have
> no idea if the second one is ok and what was the problem.

 If "type ‘GraphicDescriptor’ is not a base type for 
type 'unographic::Graphic’" was the only thing gcc said about it, then it's 
probably a gcc bug, because clearly it is a base type for the class.

 That said, the API appears to be broken. Graphic::Init() checks for previous 
value mpGraphic, so that suggests it is possible to re-initialize the class 
using this call. But then using this init() call first and later one of the 
ones inherited from GraphicDescript will leave mpGraphic inconsistent. 
Presumably the proper fix is to get rid of the init() calls and use directly 
ctors for initialization.

-- 
 Lubos Lunak
 l.lunak at suse.cz