[Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part IX getLength() to isEmpty()

Ivan Timofeev timofeev.i.s at gmail.com
Sat Dec 17 04:39:13 PST 2011


15.12.2011 05:18, Olivier Hallot пишет:
> Please find attached a partial fix for Easy Hack FDO43460
>
> Part IX
> Module
> connectivity
>
> (this one is quite big)

it seems that you forgot to change the second condition:
-            if ( !pMasterFields->getLength() || 
!pDetailFields->getLength() )
+            if ( pMasterFields->isEmpty() || !pDetailFields->getLength() )

I changed !pDetailFields->getLength() to pDetailFields->isEmpty() and 
pushed:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1777c09a0781710c309e500f680e6f95c080ca86

and also:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=198a99861e14cf5c001177b1192cebfe4708ea05
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d18daeff771b255207bb30d428540d9ebd28ec32

Don't shy to make such trivial fixes in lines that you modify! ;)

Thank you,
Ivan


More information about the LibreOffice mailing list