[Libreoffice] [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

Marcel Metz mmetz at adrian-broher.net
Wed Dec 21 07:18:46 PST 2011


Hello lo-devs,

I've tested the patch with 'make check', but would like to point out
that the reviewer should take special care of the change in
'sc/source/core/tool/chgtrack.cxx:3140-3160'. From my understanding
of the code the tools Table does not allow multiple entires with the
same key so that this assertion for double keys is not required but
maybe I'm missing something.

regards Marcel Metz

---
 sc/inc/chgtrack.hxx                                |   42 ++++--
 sc/source/core/tool/chgtrack.cxx                   |  138
++++++++++----------
 sc/source/filter/xcl97/XclExpChangeTrack.cxx       |   12 +-
 .../filter/xml/XMLChangeTrackingExportHelper.cxx   |    2 +-
 .../filter/xml/XMLChangeTrackingExportHelper.hxx   |    6 +-
 sc/source/ui/inc/acredlin.hxx                      |    8 +-
 sc/source/ui/miscdlgs/acredlin.cxx                 |   99 +++++++-------
 7 files changed, 167 insertions(+), 140 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Replace-ScChangeActionTable-with-std-map.patch
Type: text/x-patch
Size: 39618 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111221/914f361b/attachment-0001.bin>


More information about the LibreOffice mailing list