[Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

Norbert Thiebaud nthiebaud at gmail.com
Wed Dec 21 08:23:05 PST 2011


On Wed, Dec 21, 2011 at 9:58 AM, Eike Rathke <erack at redhat.com> wrote:
> Hi,
>
> On Tuesday, 2011-12-20 17:46:22 -0600, Norbert Thiebaud wrote:
>
>> > IMHO (other might disagree), we should get rid of these opaque names in the
>> > long run anyway. INPATH and OUTPATH should only be "build" or "host".
>> >
>>
>> Sure, but then stuff like rm -fr */$INPATH may end-up having
>> unexpected consequences...
>>
>> once everything is on workdir (and even in solver) then sure no
>> problem to use build/host... but as long as INPATH is in individual
>> module that maybe a bit dangerous to change with such common terms.
>
> INPATH is also used by several scripts in solenv/bin/ and others.
>
> Still, there should be a way to have non-dbgutil and dbgutil builds (or
> builds with different switches, whatever) in parallel. So we'd need
> _some_ mechanism to differentiate between output directories.

imo: that should eventually be separate workdir... but as long as we
still have dmake modules around, I would not mess with IN/OUTPATH...
(work*risk)/reward ratio is really not appealing.

Norbert


More information about the LibreOffice mailing list