[Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

Marcel Metz mmetz at adrian-broher.net
Wed Dec 21 12:10:54 PST 2011


On 21.12.2011 20:27, Michael Stahl wrote:
>
> pushed to master, with 2 small corrections:
>
> this here inverted the logic, Get == 0 means not found:
> -   if ( p != pAct && !rTable.Get( p->GetActionNumber() ) )
> +   if ( p != pAct && rMap.find( p->GetActionNumber() ) != rMap.end() )
>
> and in ScChangeTrack::Reject, the old code iterated from end to start
> (dunno if that is important there, but why not use a reverse_iterator)
>
> thanks for the patch!

Thanks for the review. You're right, the reverse_iterator is closer to
the old behaviour.

regards Marcel


More information about the LibreOffice mailing list